On Thu, Nov 7, 2013 at 7:24 PM, Joe Perches <joe@xxxxxxxxxxx> wrote: > On Fri, 2013-11-08 at 14:20 +1100, NeilBrown wrote: >> In particular fix the capitalisation of GPIO and LED and >> correct TCA6507_MAKE_CPIO, but also rewrite the comment about >> platform-data to include reference to devicetree. > > trivia: > >> diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c > [] >> @@ -8,7 +8,7 @@ >> * double-blink. >> * >> * This driver can configure each line either as a 'GPIO' which is out-only >> - * (no pull-up) or as an LED with variable brightness and hardware-assisted >> + * (pull-up resistor required) or as an LED with variable brightness and hardware-assisted >> * blinking. > > Please rewrap the comment to 80 cols. > > Hi Neil, Could you update your patch according Joe's review. Thanks, -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
