On Tuesday, October 15, 2013 2:32 AM, Maximilian Guntner wrote: > > The NXP PCA9685 supports 16 channels/leds using a 12-bit PWM (4095 > levels of brightness) > This driver supports configuration using platform_data. > > Signed-off-by: Maximilian Güntner <maximilian.guentner@xxxxxxxxx> I added some nit-picking comments. :-) > --- > drivers/leds/Kconfig | 10 ++ > drivers/leds/Makefile | 1 + > drivers/leds/leds-pca9685.c | 219 +++++++++++++++++++++++++++++ > include/linux/platform_data/leds-pca9685.h | 34 +++++ > 4 files changed, 264 insertions(+) > create mode 100644 drivers/leds/leds-pca9685.c > create mode 100644 include/linux/platform_data/leds-pca9685.h > [.....] > + > +#include <linux/module.h> > +#include <linux/string.h> > +#include <linux/delay.h> > +#include <linux/ctype.h> > +#include <linux/leds.h> > +#include <linux/err.h> > +#include <linux/i2c.h> > +#include <linux/workqueue.h> > +#include <linux/slab.h> > + > +#include <linux/platform_data/leds-pca9685.h> Please, sort these header inclusions alphabetically for better readability. [.....] > +#ifndef __LINUX_PCA9685_H > +#define __LINUX_PCA9685_H You can add one empty line here. > +#include <linux/leds.h> > + Best regards, Jingoo Han -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
