On 27 September 2013 22:46, Bryan Wu <cooloney@xxxxxxxxx> wrote: > On Fri, Sep 27, 2013 at 10:02 AM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: >> On 27 September 2013 22:23, Bryan Wu <cooloney@xxxxxxxxx> wrote: >>> On Fri, Sep 27, 2013 at 4:36 AM, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote: >>>> 'of_match_ptr' is defined in linux/of.h. Include it explicitly. >>>> >>> >>> Why we need this? I think it is include from of_gpio.h or >>> of_platform.h. And I tried to build these driver files you patched, >>> there is no error or warning for this. >>> >>> Is there any error or warning you met? >> >> No, this is only a coding style best practice to include the header >> files explicitly as is widely followed across the kernel. This will >> avoid breakage in the future if the indirect inclusion is moved or >> removed . >> > > OK, I assumed some building failures. Please help me to fold all you 6 > patches together and we can apply them in one patch. Ok. I will squash them together and send it to you in sometime. Thanks. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
