Re: [PATCH 1/1] leds: blinkm: Remove redundant break

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 12, 2013 at 12:33 AM, Jan-Simon Möller <dl9pf@xxxxxx> wrote:
> Acked-by.
>
> --
>
> Dipl.-Ing.
> Jan-Simon Möller
>
> jansimon.moeller@xxxxxx
> On Thursday 12 September 2013 09:50:29 Sachin Kamat wrote:
>> 'break' after return is redundant. Remove it.
>>

Sure, I will merge that with Jan-Simon's Ack and queue it for 3.13 kernel.

Thanks,
-Bryan

>> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
>> ---
>>  drivers/leds/leds-blinkm.c |    3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
>> index a502678..66d0a57 100644
>> --- a/drivers/leds/leds-blinkm.c
>> +++ b/drivers/leds/leds-blinkm.c
>> @@ -161,13 +161,10 @@ static ssize_t show_color_common(struct device *dev,
>> char *buf, int color) switch (color) {
>>       case RED:
>>               return scnprintf(buf, PAGE_SIZE, "%02X\n", data->red);
>> -             break;
>>       case GREEN:
>>               return scnprintf(buf, PAGE_SIZE, "%02X\n", data->green);
>> -             break;
>>       case BLUE:
>>               return scnprintf(buf, PAGE_SIZE, "%02X\n", data->blue);
>> -             break;
>>       default:
>>               return -EINVAL;
>>       }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux