+ LED mailing list On Tue, Aug 06, 2013 at 08:59:13AM -0300, Ezequiel Garcia wrote: > On Sun, Jun 02, 2013 at 05:53:13PM +0200, Jens Renner (EFE) wrote: > > Register a MTD LED trigger called "mtd-disk" (similar to the "ide-disk" and > > "nand-disk" triggers) to indicate read / write / erase acitivity. Panic writes > > and OOB reads / writes are not covered as of now. The trigger is global as it > > does not discriminate between individual devices or partitions. > > The patch uses the generic LED trigger interface which can be configured via > > SYSFS (/sys/class/leds/<name>/trigger) or DTS file entry for "gpio-leds" > > (linux,default-trigger = "mtd-disk"). > > > > Since the MTD framework is independant of the memory devices, driver-specific > > LED triggers like "nand-disk" will indicate a subset of all MTD activity. > > > > Tested on Microblaze architecture with Micron N25Q256A serial flash. > > Added a bit of documentation (including other new LED triggers). > > Thanks for doing this and sorry for such late feedback. > For some reason I thought this would be already merged, > and now looking at it in detail I have some comments about it. > > I'm Ccing Brian, David and Artem just to make sure I don't say something > foolish. > > I think you should re-work this entirely and add this trigger as a > selectable module just as the rest of the led triggers do it. > See drivers/led/trigger/ for examples. > > In addition you could move nand-disk over there as well. In case this is waiting on another opinion: I agree. And it doesn't make sense to make calls to LED function on every MTD read/write even if we don't have LED support compiled in. The existing LED triggers in drivers/leds/trigger don't add any overhead when they are not enabled in Kconfig. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
