Re: [PATCH] leds: pca9633: Add hardware blink support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 22, 2013 at 03:07:24PM -0700, Bryan Wu wrote:
> On Mon, Jul 15, 2013 at 4:18 PM, Mark A. Greer <mgreer@xxxxxxxxxxxxxxx> wrote:
> > From: "Mark A. Greer" <mgreer@xxxxxxxxxxxxxxx>
> >
> > Add hardware blink support to the pca9633 driver.
> >
> > NOTE: This patch violates the leds infrastructure
> > since the hardware only supports blinking all LEDs
> > with the same delay_on/delay_off rates.  That is,
> > only the LEDs that are set to blink will actually
> > blink but all LEDs that are set to blink will blink
> > in identical fashion.  The delay_on/delay_off values
> > of the last LED that is set to blink will be used
> > for all of the blinking LEDs.
> >
> 
> Sorry for the delay, I'm basically OK for this RFC. And could you
> please put some NOTE in the code as a comment as well as the patch
> description.

OK.

> After that, I will put this patch on my devel branch.

Thanks Bryan.  I just submitted v2 with your issue [hopefully] addressed:

	http://www.spinics.net/lists/linux-leds/msg01057.html

Mark
--
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux