On Mon, Jun 17, 2013 at 9:42 AM, Bryan Wu <cooloney@xxxxxxxxx> wrote:
> On Fri, Jun 14, 2013 at 8:58 PM, Alexander Shiyan <shc_work@xxxxxxx> wrote:
>> Patch adds a stubs for of_get_next_child and of_get_next_available_child
>> non-OF builds.
>>
>
> So how other drivers deal with this non-OF builds if they're using
> of_get_next_child()?
>
> And this patch is just for Device Tree core stuff, please resend it to
> Device Tree mail list.
>
> Thanks,
> -Bryan
>
I guess you probably need to fix it in the driver firstly like others doing:
#ifdef CONFIG_OF
/* DT related probing code, like of_get_next_child() */
...
#else
/* non-DT probing code without of_get_next_child() */
#endif
After we fix this, we can try to push your OF core patch to Device Tree.
Thanks,
-Bryan
>> Signed-off-by: Alexander Shiyan <shc_work@xxxxxxx>
>> ---
>> include/linux/of.h | 16 ++++++++++++++--
>> 1 file changed, 14 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/linux/of.h b/include/linux/of.h
>> index 1fd08ca..df0e644 100644
>> --- a/include/linux/of.h
>> +++ b/include/linux/of.h
>> @@ -366,8 +366,17 @@ static inline bool of_have_populated_dt(void)
>> return false;
>> }
>>
>> -#define for_each_child_of_node(parent, child) \
>> - while (0)
>> +static struct device_node *of_get_next_child(const struct device_node *node,
>> + struct device_node *prev)
>> +{
>> + return NULL;
>> +}
>> +
>> +static struct device_node *of_get_next_available_child(
>> + const struct device_node *node, struct device_node *prev)
>> +{
>> + return NULL;
>> +}
>>
>> static inline struct device_node *of_get_child_by_name(
>> const struct device_node *node,
>> @@ -376,6 +385,9 @@ static inline struct device_node *of_get_child_by_name(
>> return NULL;
>> }
>>
>> +#define for_each_child_of_node(parent, child) \
>> + while (0)
>> +
>> static inline int of_get_child_count(const struct device_node *np)
>> {
>> return 0;
>> --
>> 1.8.1.5
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
