On Mon, May 20, 2013 at 8:23 AM, Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> wrote: > Since commit ab78029 (drivers/pinctrl: grab default handles from device core) > we can rely on device core for handling pinctrl, so remove > devm_pinctrl_get_select_default() from the driver. > > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> Good catch, thanks a lot. It was reported by Stephen Warren several days ago. I will merge it soon. -Bryan > --- > drivers/leds/leds-gpio.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c > index 555ee46e..970de8f 100644 > --- a/drivers/leds/leds-gpio.c > +++ b/drivers/leds/leds-gpio.c > @@ -20,7 +20,6 @@ > #include <linux/slab.h> > #include <linux/workqueue.h> > #include <linux/module.h> > -#include <linux/pinctrl/consumer.h> > #include <linux/err.h> > > struct gpio_led_data { > @@ -235,13 +234,8 @@ static int gpio_led_probe(struct platform_device *pdev) > { > struct gpio_led_platform_data *pdata = pdev->dev.platform_data; > struct gpio_leds_priv *priv; > - struct pinctrl *pinctrl; > int i, ret = 0; > > - pinctrl = devm_pinctrl_get_select_default(&pdev->dev); > - if (IS_ERR(pinctrl)) > - dev_warn(&pdev->dev, > - "pins are not configured from the driver\n"); > > if (pdata && pdata->num_leds) { > priv = devm_kzalloc(&pdev->dev, > -- > 1.8.1.2 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-leds" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html