On Fri, Apr 26, 2013 at 1:34 AM, Kim, Milo <Milo.Kim@xxxxxx> wrote: > It looks good to me, either. Just two minor points here. > One is the name of vendor. I would suggest name changes from 'national' to 'ti'. Why? Our datasheet for LP5521 says this component is manufactured by National Semiconductor ... was the component sold over to Texas Instruments? If that is the case we can actually be diplomatic and support both, there is no upper limit in the number of compatible strings we can have. > The other is the size of arrays, current configuration. The size is fixed as 3. > LP5521 has max tree channels, so no problem with this device. > However, LP5523 has max 9 channels and LP5562 has 4 channels. OK seems like it can be fixed up as you describe... Thanks! Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html