Hi Magnus, Thanks for the review. On Wednesday 24 April 2013 18:37:57 Magnus Damm wrote: > On Wed, Apr 24, 2013 at 1:06 AM, Laurent Pinchart wrote: > > The Timer Pulse Unit (TPU is a 4-channels 16-bit timer used to generate > > waveforms. This driver exposes PWM functions through the PWM API for > > other drivers to use. > > > > The code is loosely based on the leds-renesas-tpu driver by Magnus Damm > > and the TPU PWM driver shipped in the Armadillo EVA 800 kernel sources. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > Tested-by: Simon Horman <horms@xxxxxxxxxxxx> > > --- > > > > drivers/pwm/Kconfig | 7 + > > drivers/pwm/Makefile | 1 + > > drivers/pwm/pwm-rmob.c | 462 ++++++++++++++++++++++++++++ > > include/linux/platform_data/pwm-rmob.h | 18 ++ > > 4 files changed, 488 insertions(+) > > create mode 100644 drivers/pwm/pwm-rmob.c > > create mode 100644 include/linux/platform_data/pwm-rmob.h > > Thanks for your efforts with this driver. The new code becomes much nicer > compared to my old driver. > > The TPU hardware block is used across several different Renesas product > lines, including R-Mobile and R-Car. So with that in mind, can you please > consider renaming this driver? > > I propose pwm-renesas-tpu.c or pwm-tpu.c instead of pwm-rmob.c. This > because this driver has nothing to do with the R mobile product line. pwm-renesas-tpu.c sounds good. I'll rename the driver accordingly and will resubmit the patch set. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
