Re: [PATCH] leds: leds-asic3: switch to using SIMPLE_DEV_PM_OPS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 25, 2013 at 11:47 PM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> Switch to using SIMPLE_DEV_PM_OPS  macro to declare the driver's
> pm_ops. It reduces code size. Also, CONFIG_PM_SLEEP is added to
> suspend/ resume functions to prevent build warnings when
> CONFIG_PM_SLEEP is not selected.
>

Sure, good change. I merged it.
Thanks,
-Bryan

> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
>  drivers/leds/leds-asic3.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/leds/leds-asic3.c b/drivers/leds/leds-asic3.c
> index b474745..cf9efe4 100644
> --- a/drivers/leds/leds-asic3.c
> +++ b/drivers/leds/leds-asic3.c
> @@ -134,6 +134,7 @@ static int asic3_led_remove(struct platform_device *pdev)
>         return mfd_cell_disable(pdev);
>  }
>
> +#ifdef CONFIG_PM_SLEEP
>  static int asic3_led_suspend(struct device *dev)
>  {
>         struct platform_device *pdev = to_platform_device(dev);
> @@ -159,11 +160,9 @@ static int asic3_led_resume(struct device *dev)
>
>         return ret;
>  }
> +#endif
>
> -static const struct dev_pm_ops asic3_led_pm_ops = {
> -       .suspend        = asic3_led_suspend,
> -       .resume         = asic3_led_resume,
> -};
> +static SIMPLE_DEV_PM_OPS(asic3_led_pm_ops, asic3_led_suspend, asic3_led_resume);
>
>  static struct platform_driver asic3_led_driver = {
>         .probe          = asic3_led_probe,
> --
> 1.7.2.5
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux