On Thu, Mar 21, 2013 at 7:09 PM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> Add CONFIG_PM_SLEEP to suspend/resume functions to fix the following
> build warning when CONFIG_PM_SLEEP is not selected. This is because
> sleep PM callbacks defined by SIMPLE_DEV_PM_OPS are only used when
> the CONFIG_PM_SLEEP is enabled.
>
> drivers/leds/leds-bd2802.c:766:12: warning: 'bd2802_suspend' defined but not used [-Wunused-function]
> drivers/leds/leds-bd2802.c:776:12: warning: 'bd2802_resume' defined but not used [-Wunused-function]
>
Thanks for catching this. I merged this patch.
-Bryan
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> ---
> drivers/leds/leds-bd2802.c | 10 +++-------
> 1 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/leds/leds-bd2802.c b/drivers/leds/leds-bd2802.c
> index 9f9177d..2db0423 100644
> --- a/drivers/leds/leds-bd2802.c
> +++ b/drivers/leds/leds-bd2802.c
> @@ -747,8 +747,7 @@ static int bd2802_remove(struct i2c_client *client)
> return 0;
> }
>
> -#ifdef CONFIG_PM
> -
> +#ifdef CONFIG_PM_SLEEP
> static void bd2802_restore_state(struct bd2802_led *led)
> {
> int i;
> @@ -785,12 +784,9 @@ static int bd2802_resume(struct device *dev)
>
> return 0;
> }
> +#endif
>
> static SIMPLE_DEV_PM_OPS(bd2802_pm, bd2802_suspend, bd2802_resume);
> -#define BD2802_PM (&bd2802_pm)
> -#else /* CONFIG_PM */
> -#define BD2802_PM NULL
> -#endif
>
> static const struct i2c_device_id bd2802_id[] = {
> { "BD2802", 0 },
> @@ -801,7 +797,7 @@ MODULE_DEVICE_TABLE(i2c, bd2802_id);
> static struct i2c_driver bd2802_i2c_driver = {
> .driver = {
> .name = "BD2802",
> - .pm = BD2802_PM,
> + .pm = &bd2802_pm,
> },
> .probe = bd2802_probe,
> .remove = bd2802_remove,
> --
> 1.7.2.5
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
