On Tue, Mar 12, 2013 at 11:57:50AM -0700, Bryan Wu wrote: > On Thu, Feb 28, 2013 at 7:21 AM, Ian Lartey <ian@xxxxxxxxxxxxxxx> wrote: > > + spinlock_t value_lock; > I think you don't need this spinlock to protect the value, the mutex is enough. You need to use a spinlock because values can be set from hard IRQ context so you can't take a mutex there. Someone should really factor this out into the framework in their copious free time, the set and schedule pattern is very common in drivers.
Attachment:
signature.asc
Description: Digital signature