On Sun, Jan 27, 2013 at 4:56 AM, Axel Lin <axel.lin@xxxxxxxxxx> wrote:
> of_find_node_by_name() returns a node pointer with refcount incremented, use
> of_node_put() on it when done.
>
> of_find_node_by_name() will call of_node_put() against from parameter,
> thus we also need to call of_node_get(from) before calling
> of_find_node_by_name().
>
Good, merged.
Thanks,
-Bryan
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
> ---
> v2:
> need to call of_node_get(pdev->dev.parent->of_node) before calling
> of_find_node_by_name().
>
> drivers/leds/leds-88pm860x.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c
> index 6be2edd4..f5b9ea3 100644
> --- a/drivers/leds/leds-88pm860x.c
> +++ b/drivers/leds/leds-88pm860x.c
> @@ -128,8 +128,10 @@ static void pm860x_led_set(struct led_classdev *cdev,
> static int pm860x_led_dt_init(struct platform_device *pdev,
> struct pm860x_led *data)
> {
> - struct device_node *nproot = pdev->dev.parent->of_node, *np;
> + struct device_node *nproot, *np;
> int iset = 0;
> +
> + nproot = of_node_get(pdev->dev.parent->of_node);
> if (!nproot)
> return -ENODEV;
> nproot = of_find_node_by_name(nproot, "leds");
> @@ -145,6 +147,7 @@ static int pm860x_led_dt_init(struct platform_device *pdev,
> break;
> }
> }
> + of_node_put(nproot);
> return 0;
> }
> #else
> --
> 1.7.9.5
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
