On Mon, Jan 28, 2013 at 3:19 PM, Kim, Milo <Milo.Kim@xxxxxx> wrote: >> -----Original Message----- >> From: Bryan Wu [mailto:cooloney@xxxxxxxxx] >> Sent: Tuesday, January 29, 2013 4:00 AM >> To: kbuild test robot >> Cc: Kim, Milo; linux-leds@xxxxxxxxxxxxxxx >> Subject: Re: [leds:devel 39/59] drivers/leds/leds-lp5521.c:615:6: error: >> 'lp5521_led_attribute_group' undeclared >> >> Milo, >> >> Do you have time to take a look at this? >> >> -Bryan >> >> On Wed, Jan 23, 2013 at 11:09 AM, kbuild test robot >> <fengguang.wu@xxxxxxxxx> wrote: >> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/cooloney/linux- >> leds.git devel >> > head: 7314a82b650c2cc48a43e269fff96a22b8af90e0 >> > commit: a2594118f274d12925ff7cbac06b8ec40bb001a7 [39/59] leds-lp55xx: >> provide common LED current setting >> > config: make ARCH=x86_64 allmodconfig >> > >> > Note: the leds/devel HEAD 7314a82 builds fine. >> > It only hurts bisectibility. >> > >> > All error/warnings: >> > >> > drivers/leds/leds-lp5521.c: In function 'lp5521_unregister_sysfs': >> >>> drivers/leds/leds-lp5521.c:615:6: error: >> 'lp5521_led_attribute_group' undeclared (first use in this function) >> > drivers/leds/leds-lp5521.c:615:6: note: each undeclared identifier >> is reported only once for each function it appears in >> > -- >> > drivers/leds/leds-lp5523.c: In function 'lp5523_unregister_sysfs': >> >>> drivers/leds/leds-lp5523.c:670:6: error: >> 'lp5523_led_attribute_group' undeclared (first use in this function) >> > drivers/leds/leds-lp5523.c:670:6: note: each undeclared identifier >> is reported only once for each function it appears in >> > >> > vim +/lp5521_led_attribute_group +615 drivers/leds/leds-lp5521.c >> > >> > 609 int i; >> > 610 >> > 611 sysfs_remove_group(&dev->kobj, &lp5521_group); >> > 612 >> > 613 for (i = 0; i < chip->num_leds; i++) >> > 614 sysfs_remove_group(&chip->leds[i].cdev.dev- >> >kobj, >> > > 615 &lp5521_led_attribute_group); >> > 616 } >> > 617 >> > 618 static void lp5521_unregister_leds(struct lp5521_chip *chip) >> > >> > --- >> > 0-DAY kernel build testing backend Open Source >> Technology Center >> > http://lists.01.org/mailman/listinfo/kbuild Intel >> Corporation > > Hi Bryan, > > I think errors are shown in the middle of merging series of patch-set. > In latest driver, no build error is found because these attributes were replaced > with attributes of the lp55xx common driver. > Please see the patch below. > > http://git.kernel.org/?p=linux/kernel/git/cooloney/linux-leds.git;a=commitdiff;h=a2594118f274d12925ff7cbac06b8ec40bb001a7 > > While I was generating a patch-set, the completed driver was built rather than > compiling each patch unit one by one. > I'll keep in mind the rule of generating patch-set. > I apologize it. > Yes, I think we need obey this rule here. Breaking bisecting will cause lots of pain for debugging. So please help to fold some patch together or rebuild this patchset (39 patches), then give me a git url. I can try to rebuilt my branch later. Thanks, -BRyan > Please let me know if I need to re-generate a patch-set. > > Best Regards, > Milo > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
