On 11/13/2012 06:05 PM, Bryan Wu wrote: > It looks fine to me, but I need a DT maintainer's ack. Stephen, could > you help on this. I will merge this patch via my tree. I'm not actually a DT maintainer; I CC'd Grant and Rob. Marek probably wants to repost the whole patch to them. Comments below. >> diff --git a/Documentation/devicetree/bindings/leds/tca6507.txt b/Documentation/devicetree/bindings/leds/tca6507.txt ... >> +LED sub-node properties: ... >> + string defining the trigger assigned to the LED. Current triggers are: >> + "backlight" - LED will act as a back-light, controlled by the framebuffer >> + system >> + "default-on" - LED will turn on >> + "heartbeat" - LED "double" flashes at a load average based rate >> + "ide-disk" - LED indicates disk activity >> + "timer" - LED flashes at a fixed, configurable rate It would be useful to point at a single canonical document that describes the triggers, rather than duplicating the list into every binding. Aside from that, I think this looks reasonable. Oh, looking at Documentation/devicetree/bindings/gpio/led.txt, should a default-state property be supported? -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
