On Tue, Oct 30, 2012 at 8:49 PM, Axel Lin <axel.lin@xxxxxxxxxx> wrote: > > > 2012/10/29 Axel Lin <axel.lin@xxxxxxxxxx> >> >> Calling INIT_WORK in blinkm_led_common_set() means we init a workqueue >> every time >> when brightness_set callback is called. >> Move INIT_WORK to blinkm_probe() so we only need to init the workqueue >> once. >> >> So we only need to init a workqueue per blinkm led rather than init a >> workqueue >> per brightness_set call. > > > Ah. the commit log and subject line is wrong. > We are using the global workqueue. > What the patch does is to avoid init work rather than workqueue per > brightness_set call. > We just need to call INIT_WORK once for the first time that structure is set > up. > > There should be no functional change with this patch. > > Regards, > Axel Right, I think I did same review when this driver posted on the list firstly. Probably it is a hardware issue. So let Jan-Simon give us some updates. If the hardware requires this specific handling, I suggest we add some comments or documents to clarify that. Thanks, -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
