Re: [PATCH 2/2] leds: lm3642: Fix up world writable sysfs files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 29, 2012 at 4:03 AM, gshark <gshark.jeong@xxxxxxxxx> wrote:
> 2012년 10월 29일 17:41, Axel Lin 쓴 글:
>
>> We don't need these sysfs files to be world writable or group writable.
>> These files are write-only, change them to S_IWUSR (0200).
>>
>> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
>> ---
>>   drivers/leds/leds-lm3642.c |    4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/leds/leds-lm3642.c b/drivers/leds/leds-lm3642.c
>> index b69acac..83fc7d7 100644
>> --- a/drivers/leds/leds-lm3642.c
>> +++ b/drivers/leds/leds-lm3642.c
>> @@ -207,7 +207,7 @@ out_strtoint:
>>         return ret;
>>   }
>>   -static DEVICE_ATTR(torch_pin, 0666, NULL, lm3642_torch_pin_store);
>> +static DEVICE_ATTR(torch_pin, S_IWUSR, NULL, lm3642_torch_pin_store);
>>     static void lm3642_deferred_torch_brightness_set(struct work_struct
>> *work)
>>   {
>> @@ -264,7 +264,7 @@ out_strtoint:
>>         return ret;
>>   }
>>   -static DEVICE_ATTR(strobe_pin, 0666, NULL, lm3642_strobe_pin_store);
>> +static DEVICE_ATTR(strobe_pin, S_IWUSR, NULL, lm3642_strobe_pin_store);
>>     static void lm3642_deferred_strobe_brightness_set(struct work_struct
>> *work)
>>   {
>
>
> It's also nice to us. Thank you Alex.
> Acked-by: G.Shark Jeong<gshark.jeong@xxxxxxxxx>
>
Also applied, thanks.
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux