On Sun, Oct 28, 2012 at 9:31 PM, Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:
> The devm_kfree function allocates memory that is released
> when a driver detaches. Thus, there is no reason to explicitly
> call devm_kfree in probe or remove functions.
>
> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
Applied, thanks,
-Bryan
> ---
> drivers/leds/leds-88pm860x.c | 9 ++-------
> 1 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c
> index b7e8cc0..6be2edd 100644
> --- a/drivers/leds/leds-88pm860x.c
> +++ b/drivers/leds/leds-88pm860x.c
> @@ -165,15 +165,13 @@ static int pm860x_led_probe(struct platform_device *pdev)
> res = platform_get_resource_byname(pdev, IORESOURCE_REG, "control");
> if (!res) {
> dev_err(&pdev->dev, "No REG resource for control\n");
> - ret = -ENXIO;
> - goto out;
> + return -ENXIO;
> }
> data->reg_control = res->start;
> res = platform_get_resource_byname(pdev, IORESOURCE_REG, "blink");
> if (!res) {
> dev_err(&pdev->dev, "No REG resource for blink\n");
> - ret = -ENXIO;
> - goto out;
> + return -ENXIO;
> }
> data->reg_blink = res->start;
> memset(data->name, 0, MFD_NAME_SIZE);
> @@ -224,9 +222,6 @@ static int pm860x_led_probe(struct platform_device *pdev)
> }
> pm860x_led_set(&data->cdev, 0);
> return 0;
> -out:
> - devm_kfree(&pdev->dev, data);
> - return ret;
> }
>
> static int pm860x_led_remove(struct platform_device *pdev)
> --
> 1.7.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
