Re: [PATCH] leds: lm3642: Return proper error in lm3642_[torch|strobe]_pin_store error paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2012년 10월 08일 12:54, Axel Lin 쓴 글:
Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
---
  drivers/leds/leds-lm3642.c |    8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/leds/leds-lm3642.c b/drivers/leds/leds-lm3642.c
index 3285006..b69acac 100644
--- a/drivers/leds/leds-lm3642.c
+++ b/drivers/leds/leds-lm3642.c
@@ -201,10 +201,10 @@ static ssize_t lm3642_torch_pin_store(struct device *dev,
  	return size;
  out:
  	dev_err(chip->dev, "%s:i2c access fail to register\n", __func__);
-	return size;
+	return ret;
  out_strtoint:
  	dev_err(chip->dev, "%s: fail to change str to int\n", __func__);
-	return size;
+	return ret;
  }
static DEVICE_ATTR(torch_pin, 0666, NULL, lm3642_torch_pin_store);
@@ -258,10 +258,10 @@ static ssize_t lm3642_strobe_pin_store(struct device *dev,
  	return size;
  out:
  	dev_err(chip->dev, "%s:i2c access fail to register\n", __func__);
-	return size;
+	return ret;
  out_strtoint:
  	dev_err(chip->dev, "%s: fail to change str to int\n", __func__);
-	return size;
+	return ret;
  }
static DEVICE_ATTR(strobe_pin, 0666, NULL, lm3642_strobe_pin_store);

You're right.  Thank you Alex.
Acked-by: G.Shark Jeong<gshark.jeong@xxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux