The lp55xx_led and lp55xx_chip structures are used for supporting LP5521 and
LP5523 device functionality.
Core structures are allocated when each driver is probed.
Unused old data code were removed.
Additional headers are included.
Signed-off-by: Milo(Woogyom) Kim <milo.kim@xxxxxx>
---
drivers/leds/leds-lp5521.c | 33 +++++++++++++++++++++------------
drivers/leds/leds-lp5523.c | 33 +++++++++++++++++++++------------
2 files changed, 42 insertions(+), 24 deletions(-)
diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
index 992984b..3735038 100644
--- a/drivers/leds/leds-lp5521.c
+++ b/drivers/leds/leds-lp5521.c
@@ -32,9 +32,12 @@
#include <linux/wait.h>
#include <linux/leds.h>
#include <linux/leds-lp5521.h>
+#include <linux/platform_data/leds-lp55xx.h>
#include <linux/workqueue.h>
#include <linux/slab.h>
+#include "leds-lp55xx-common.h"
+
#define LP5521_PROGRAM_LENGTH 32 /* in bytes */
#define LP5521_MAX_LEDS 3 /* Maximum number of LEDs */
@@ -743,24 +746,30 @@ static int __devinit lp5521_probe(struct i2c_client *client,
struct lp5521_platform_data *old_pdata;
int ret, i, old_led;
u8 buf;
+ struct lp55xx_chip *chip;
+ struct lp55xx_led *led;
+ struct lp55xx_platform_data *pdata = client->dev.platform_data;
- old_chip = devm_kzalloc(&client->dev, sizeof(*old_chip), GFP_KERNEL);
- if (!old_chip)
- return -ENOMEM;
-
- i2c_set_clientdata(client, old_chip);
- old_chip->client = client;
-
- old_pdata = client->dev.platform_data;
-
- if (!old_pdata) {
+ if (!pdata) {
dev_err(&client->dev, "no platform data\n");
return -EINVAL;
}
- mutex_init(&old_chip->lock);
+ chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
+ if (!chip)
+ return -ENOMEM;
+
+ led = devm_kzalloc(&client->dev,
+ sizeof(*led) * pdata->num_channels, GFP_KERNEL);
+ if (!led)
+ return -ENOMEM;
+
+ chip->cl = client;
+ chip->pdata = pdata;
+
+ mutex_init(&chip->lock);
- old_chip->pdata = old_pdata;
+ i2c_set_clientdata(client, led);
if (old_pdata->setup_resources) {
ret = old_pdata->setup_resources();
diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c
index 75fc7d5..91f42fc 100644
--- a/drivers/leds/leds-lp5523.c
+++ b/drivers/leds/leds-lp5523.c
@@ -32,9 +32,12 @@
#include <linux/wait.h>
#include <linux/leds.h>
#include <linux/leds-lp5523.h>
+#include <linux/platform_data/leds-lp55xx.h>
#include <linux/workqueue.h>
#include <linux/slab.h>
+#include "leds-lp55xx-common.h"
+
#define LP5523_REG_ENABLE 0x00
#define LP5523_REG_OP_MODE 0x01
#define LP5523_REG_RATIOMETRIC_MSB 0x02
@@ -888,24 +891,30 @@ static int __devinit lp5523_probe(struct i2c_client *client,
struct lp5523_chip *old_chip;
struct lp5523_platform_data *old_pdata;
int ret, i, old_led;
+ struct lp55xx_chip *chip;
+ struct lp55xx_led *led;
+ struct lp55xx_platform_data *pdata = client->dev.platform_data;
- old_chip = devm_kzalloc(&client->dev, sizeof(*old_chip), GFP_KERNEL);
- if (!old_chip)
- return -ENOMEM;
-
- i2c_set_clientdata(client, old_chip);
- old_chip->client = client;
-
- old_pdata = client->dev.platform_data;
-
- if (!old_pdata) {
+ if (!pdata) {
dev_err(&client->dev, "no platform data\n");
return -EINVAL;
}
- mutex_init(&old_chip->lock);
+ chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
+ if (!chip)
+ return -ENOMEM;
+
+ led = devm_kzalloc(&client->dev,
+ sizeof(*led) * pdata->num_channels, GFP_KERNEL);
+ if (!led)
+ return -ENOMEM;
+
+ chip->cl = client;
+ chip->pdata = pdata;
+
+ mutex_init(&chip->lock);
- old_chip->pdata = old_pdata;
+ i2c_set_clientdata(client, led);
if (old_pdata->setup_resources) {
ret = old_pdata->setup_resources();
--
1.7.9.5
Best Regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
