On Mon, Sep 24, 2012 at 8:58 AM, gshark <gshark.jeong@xxxxxxxxx> wrote:
> 2012년 09월 22일 15:40, Axel Lin 쓴 글:
>
>> Use regmap_update_bits() to replace regmap_read() + regmap_write().
>> With this patch, we only show the error message when regmap_update_bits()
>> fails.
>
> Looks good..You're right. Thank you Alex.
>>
>>
>> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
>
> Acked-by: G.Shark Jeong<gshark.jeong@xxxxxxxxx>
>
Thanks, applied to my for-next.
-Bryan
>> ---
>> drivers/leds/leds-lm3642.c | 15 +++------------
>> 1 file changed, 3 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/leds/leds-lm3642.c b/drivers/leds/leds-lm3642.c
>> index 924853b..3285006 100644
>> --- a/drivers/leds/leds-lm3642.c
>> +++ b/drivers/leds/leds-lm3642.c
>> @@ -95,23 +95,14 @@ struct lm3642_chip_data {
>> /* chip initialize */
>> static int __devinit lm3642_chip_init(struct lm3642_chip_data *chip)
>> {
>> - unsigned int reg_val;
>> int ret;
>> struct lm3642_platform_data *pdata = chip->pdata;
>> /* set enable register */
>> - ret = regmap_read(chip->regmap, REG_ENABLE, ®_val);
>> + ret = regmap_update_bits(chip->regmap, REG_ENABLE,
>> EX_PIN_ENABLE_MASK,
>> + pdata->tx_pin);
>> if (ret < 0)
>> - goto out;
>> -
>> - reg_val &= (~EX_PIN_ENABLE_MASK);
>> - reg_val |= pdata->tx_pin;
>> - ret = regmap_write(chip->regmap, REG_ENABLE, reg_val);
>> - if (ret < 0)
>> - goto out;
>> -
>> -out:
>> - dev_err(chip->dev, "Failed to read REG_ENABLE Register\n");
>> + dev_err(chip->dev, "Failed to update REG_ENABLE
>> Register\n");
>> return ret;
>> }
>>
>
>
--
Bryan Wu <bryan.wu@xxxxxxxxxxxxx>
Kernel Developer +86.186-168-78255 Mobile
Canonical Ltd. www.canonical.com
Ubuntu - Linux for human beings | www.ubuntu.com
--
To unsubscribe from this list: send the line "unsubscribe linux-leds" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
