On Wed, Aug 29, 2012 at 03:50:00PM +0100, Krystian Garbaciak wrote: > Because, for some regulators, this is required: val += fvol->offset, > I was only able to reduce it to the following form. What on earth makes you say this? The above is obviously linear. Besides, you're missing several points here. One is that you should be using the framework features, another is that you should be implementing _sel. > > > + bits = da906x_reg_read(hw, DA906X_REG_STATUS_D); > > > + if (bits < 0) > > > + return IRQ_HANDLED; > > If you fail to detect an interrupt you report that you handled one...? > For me there is no sensible return value for this case. IRQ_NONE. -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
