On Wed, Aug 22, 2012 at 1:43 PM, Kim, Milo <Milo.Kim@xxxxxx> wrote: >> > LP5523 can drive up to 9 channels. Leds can be controlled directly >> via >> > -the led class control interface. Channels have generic names: >> > +the led class control interface. >> > +The name of each channel is configurable in the platform data. >> > +If the name is NULL, channels have generic names: >> > lp5523:channelx where x is 0...8 > >> Why we need a test here "pdata->label ?:"? From the document, looks >> like we use lp5523:channel%d as default. > > To define the channel name, we have three options. > a) using 'name' field for each channel > b) using 'label' field without 'name' > c) default : neither data is defined > > So I would change the description as below. > Thanks for this clarification. I'm fine with this, please resubmit patches. -Bryan > Signed-off-by: Milo(Woogyom) Kim <milo.kim@xxxxxx> > --- > Documentation/leds/leds-lp5523.txt | 18 ++++++++++++++++-- > 1 files changed, 16 insertions(+), 2 deletions(-) > > diff --git a/Documentation/leds/leds-lp5523.txt b/Documentation/leds/leds-lp5523.txt > index fad2feb..120fdfe 100644 > --- a/Documentation/leds/leds-lp5523.txt > +++ b/Documentation/leds/leds-lp5523.txt > @@ -10,8 +10,22 @@ Contact: Samu Onkalo (samu.p.onkalo-at-nokia.com) > Description > ----------- > LP5523 can drive up to 9 channels. Leds can be controlled directly via > -the led class control interface. Channels have generic names: > -lp5523:channelx where x is 0...8 > +the led class control interface. > +The name of each channel is configurable in the platform data - name and label. > +There are three options to make the channel name. > + > +a) Define the 'name' in the platform data > +To make specific channel name, then use 'name' platform data. > +/sys/class/leds/R1 (name: 'R1') > +/sys/class/leds/B1 (name: 'B1') > + > +b) Use the 'label' with no 'name' field > +For one device name with channel number, then use 'label'. > +/sys/class/leds/RGB:channelN (label: 'RGB', N: 0 ~ 8) > + > +c) Default > +If both fields are NULL, 'lp5523' is used by default. > +/sys/class/leds/lp5523:channelN (N: 0 ~ 8) > > The chip provides 3 engines. Each engine can control channels without > interaction from the main CPU. Details of the micro engine code can be found > -- > 1.7.2.5 > > > Best Regards, > Milo > > > -- Bryan Wu <bryan.wu@xxxxxxxxxxxxx> Kernel Developer +86.186-168-78255 Mobile Canonical Ltd. www.canonical.com Ubuntu - Linux for human beings | www.ubuntu.com -- To unsubscribe from this list: send the line "unsubscribe linux-leds" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
