On Tue, Aug 01, 2006 at 12:25:48PM -0400, Neil Horman wrote:
> Patch to clean up module initalization for apm.c. I had started by auditing for
> proper return code checks in misc_register, but I found that in the event of an
> initalization failure, a proc file and a kernel thread were left hanging out.
> this patch properly cleans up those loose ends on any initalization failure.
> --- a/arch/i386/kernel/apm.c
> +++ b/arch/i386/kernel/apm.c
> - misc_register(&apm_device);
> + if (misc_register(&apm_device)) {
> + printk(KERN_ERR "apm: Unable to register misc device\n");
> + ret = -ENOMEM;
> + goto out_thread;
misc_register() can fail for reasons other than ENOMEM.
-
To unsubscribe from this list: send the line "unsubscribe linux-laptop" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
