> -----Original Message-----
> From: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
> Sent: Monday, March 17, 2025 2:33 PM
> To: Chia-Yu Chang (Nokia) <chia-yu.chang@xxxxxxxxxxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; dave.taht@xxxxxxxxx; pabeni@xxxxxxxxxx; jhs@xxxxxxxxxxxx; kuba@xxxxxxxxxx; xiyou.wangcong@xxxxxxxxx; jiri@xxxxxxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; horms@xxxxxxxxxx; andrew+netdev@xxxxxxx; donald.hunter@xxxxxxxxx; ast@xxxxxxxxxxx; liuhangbin@xxxxxxxxx; shuah@xxxxxxxxxx; linux-kselftest@xxxxxxxxxxxxxxx; ij@xxxxxxxxxx; ncardwell@xxxxxxxxxx; Koen De Schepper (Nokia) <koen.de_schepper@xxxxxxxxxxxxxxxxxxx>; g.white <g.white@xxxxxxxxxxxxx>; ingemar.s.johansson@xxxxxxxxxxxx; mirja.kuehlewind@xxxxxxxxxxxx; cheshire@xxxxxxxxx; rs.ietf@xxxxxx; Jason_Livingood@xxxxxxxxxxx; vidhi_goel <vidhi_goel@xxxxxxxxx>; Olga Albisser <olga@xxxxxxxxxxxx>; Olivier Tilmans (Nokia) <olivier.tilmans@xxxxxxxxx>; Bob Briscoe <research@xxxxxxxxxxxxxx>; Henrik Steen <henrist@xxxxxxxxxxx>
> Subject: Re: [PATCH v4 iproute2-next 1/1] tc: add dualpi2 scheduler module
>
>
> CAUTION: This is an external email. Please be very careful when clicking links or opening attachments. See the URL nok.it/ext for additional information.
>
>
>
> On Sun, 16 Mar 2025 16:39:17 +0100
> chia-yu.chang@xxxxxxxxxxxxxxxxxxx wrote:
>
> > +static int get_packets(uint32_t *val, const char *arg) {
> > + unsigned long res;
> > + char *ptr;
> > +
> > + if (!arg || !*arg)
> > + return -1;
> > + res = strtoul(arg, &ptr, 10);
> > + if (!ptr || ptr == arg ||
> > + (strcmp(ptr, "p") && strcmp(ptr, "pkt") && strcmp(ptr, "pkts") &&
> > + strcmp(ptr, "packet") && strcmp(ptr, "packets")))
> > + return -1;
>
> No shortcuts please.
> We ran into this with matches() and arg conflicts already.
Thanks for the feedback, and I will use matches() between ptr and "pkts" and matches() between ptr and "packets".
Would this be ok or you expect further things to be modified? Many thanks.
Chia-Yu
