On Thu, Mar 13, 2025 at 2:12 PM Benno Lossin <benno.lossin@xxxxxxxxx> wrote: > > On Thu Mar 13, 2025 at 6:50 PM CET, Tamir Duberstein wrote: > > On Thu, Mar 13, 2025 at 10:11 AM Benno Lossin <benno.lossin@xxxxxxxxx> wrote: > >> > >> > >> With doing `allow(clippy::incompatible_msrv)`, I meant doing that > >> globally, not having a module to re-export the functions :) > > > > Yeah, but I think that's too big a hammer. It's a useful warning, and > > it doesn't accept per-item configuration. > > Hmm, I don't think it's as useful. We're going to be using more unstable > features until we eventually bump the minimum version when we can > disable `RUSTC_BOOTSTRAP=1`. From that point onwards, it will be very > useful, but before that I don't think that it matters too much. Maybe > the others disagree. I'd rather keep this narrowly scoped for now -- putting the genie back in the bottle later is usually harder. > > Why don't we want host programs to have the same warnings applied? Why > > don't we want it for all those other crates? > > I have never looked at the rust hostprogs before, so I'm missing some > context here. > > I didn't enable them, because they are currently being compiled without > any unstable features and I thought we might want to keep that. (though > I don't really see a reason not to compile them with unstable features > that we also use for the kernel crate) > > > I'd expect we want uniform diagnostics settings throughout which is > > why these things are in the Makefile rather than in individual crates > > in the first place. > > > > Your patch sidesteps the problems I'm having by not applying these > > lints to host crates, but I think we should. > > We're probably working on some stuff that Miguel's new build system will > do entirely differently. So I wouldn't worry too much about getting it > perfect, as it will be removed in a couple cycles. I got it working, but it's pretty messy. Let's discuss on v3.
