On Sat 2025-03-08 07:52:49, Tamir Duberstein wrote: > On Sat, Mar 8, 2025 at 7:51 AM Tamir Duberstein <tamird@xxxxxxxxx> wrote: > > > > On Fri, Mar 7, 2025 at 11:49 PM Kees Cook <kees@xxxxxxxxxx> wrote: > > > > > > On Fri, Mar 07, 2025 at 05:08:55PM -0500, Tamir Duberstein wrote: > > > > This is one of just 3 remaining "Test Module" kselftests (the others > > > > being bitmap and scanf), the rest having been converted to KUnit. > > > > > > > > I tested this using: > > > > > > > > $ tools/testing/kunit/kunit.py run --arch arm64 --make_options LLVM=1 printf > > > > > > > > I have also sent out a series converting scanf[0]. > > > > > > > > Link: https://lore.kernel.org/all/20250204-scanf-kunit-convert-v3-0-386d7c3ee714@xxxxxxxxx/T/#u [0] > > > > > > > > Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx> > > > > --- > > > > Changes in v6: > > > > - Use __printf correctly on `__test`. (Petr Mladek) > > > > - Rebase on linux-next. > > > > > > Thanks for doing this! > > > > > > If Petr, Rasmus, Andy, and/or others Ack this I can carry it in my > > > "lib/ kunit tests move to lib/tests/" tree, as that's where all the > > > infrastructure in lib/tests/ exists. > > > > I think the plan is to take it through the printk tree. It would be much easier when Kees takes it together with the move to lib/texts. It causes several conflicts... Kees, could you take it, please? Note that %pGg test currently fails in linux-next. It is a regression caused by a change in tracing code and should be fixed in the tracing code, see https://lore.kernel.org/all/Z9L5HsVzQ0bVZtjp@xxxxxxxxxxxxxxx/ Best Regards, Petr