Hi Madhavan, On Tue, Mar 11, 2025 at 02:11:29PM +0530, Madhavan Srinivasan wrote: > Build break was reported in the powerpc mailing list for next-20250218 with below errors > > make[1]: Nothing to be done for 'all'. > BUILD_TARGET=/root/venkat/linux-next/tools/testing/selftests/powerpc/mm; mkdir -p $BUILD_TARGET; make OUTPUT=$BUILD_TARGET -k -C mm all > CC pkey_exec_prot > In file included from pkey_exec_prot.c:18: > /root/venkat/linux-next/tools/testing/selftests/powerpc/include/pkeys.h: In function ‘pkeys_unsupported’: > /root/venkat/linux-next/tools/testing/selftests/powerpc/include/pkeys.h:96:34: error: ‘PKEY_UNRESTRICTED’ undeclared (first use in this function) > 96 | pkey = sys_pkey_alloc(0, PKEY_UNRESTRICTED); > | ^~~~~~~~~~~~~~~~~ > > https://lore.kernel.org/all/20250113170619.484698-2-yury.khrustalev@xxxxxxx/ patchset > has been queued to arm64/for-next/pkey_unrestricted which is causing a build break > in the selftest/powerpc builds. > > Commit 6d61527d931ba ("mm/pkey: Add PKEY_UNRESTRICTED macro") added a macro > PKEY_UNRESTRICTED to handle implicit literal value of 0x0 (which is "unrestricted"). > Add the same to selftest/powerpc/pkeys.h to fix the reported build break. > > Reported-by: Venkat Rao Bagalkote <venkat88@xxxxxxxxxxxxx> > Closes: https://lore.kernel.org/lkml/3267ea6e-5a1a-4752-96ef-8351c912d386@xxxxxxxxxxxxx/T/ > Tested-by: Venkat Rao Bagalkote <venkat88@xxxxxxxxxxxxx> > Signed-off-by: Madhavan Srinivasan <maddy@xxxxxxxxxxxxx> > --- > Catalin, can you take this fix via arm64/for-next/pkey_unrestricted? > Patch applies clean on top of arm64/for-next/pkey_unrestricted I'll take it, sorry for the break. I did not realise powerpc duplicates those definitions. -- Catalin
