Re: [PATCH v9 5/6] scanf: tidy header `#include`s

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 07, 2025 at 06:27:38AM -0500, Tamir Duberstein wrote:
> Remove the unused `kernel.h`. Replace `string.h` with `sprintf.h` as the
> former doesn't seem to be used directly.

...

>  #include <kunit/test.h>

+ array_size.h

>  #include <linux/bitops.h>

+ bug.h // BUILD_BUG_ON()
+ errno.h // actually asm/errno.h, but in C code the linux/* will suffice

> -#include <linux/kernel.h>

This was used like a "proxy" header to a lot, see around.

>  #include <linux/module.h>
>  #include <linux/overflow.h>
>  #include <linux/prandom.h>
>  #include <linux/slab.h>
> -#include <linux/string.h>
> +#include <linux/sprintf.h>

+ types.h // u32, __scanf, ...

...

Note,the above I made based on the context of your changes, I haven't checked
the resulting file in full, please do it yourself.

-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux