On Thu, Mar 6, 2025 at 12:54 PM Taehee Yoo <ap420073@xxxxxxxxx> wrote:
>
> When a queue is restarted, it sets MRU to 0 for stopping packet flow.
> MRU variable is a member of vnic_info[], the first vnic_info is default
> and the second is ntuple.
> Only when ntuple is enabled(ethtool -K eth0 ntuple on), vnic_info for
> ntuple is allocated in init logic.
> The bp->nr_vnics indicates how many vnic_info are allocated.
> However bnxt_queue_{start | stop}() accesses vnic_info[BNXT_VNIC_NTUPLE]
> regardless of ntuple state.
>
> Fixes: b9d2956e869c ("bnxt_en: stop packet flow during bnxt_queue_stop/start")
> Signed-off-by: Taehee Yoo <ap420073@xxxxxxxxx>
> ---
>
> v2:
> - No changes.
>
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index d09986308582..c9d37fea5d32 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -15635,7 +15635,7 @@ static int bnxt_queue_start(struct net_device *dev, void *qmem, int idx)
> cpr = &rxr->bnapi->cp_ring;
> cpr->sw_stats->rx.rx_resets++;
>
> - for (i = 0; i <= BNXT_VNIC_NTUPLE; i++) {
> + for (i = 0; i <= bp->nr_vnics; i++) {
> vnic = &bp->vnic_info[i];
>
> rc = bnxt_hwrm_vnic_set_rss_p5(bp, vnic, true);
> @@ -15663,7 +15663,7 @@ static int bnxt_queue_stop(struct net_device *dev, void *qmem, int idx)
> struct bnxt_vnic_info *vnic;
> int i;
>
> - for (i = 0; i <= BNXT_VNIC_NTUPLE; i++) {
> + for (i = 0; i <= bp->nr_vnics; i++) {
> vnic = &bp->vnic_info[i];
> vnic->mru = 0;
> bnxt_hwrm_vnic_update(bp, vnic,
> --
> 2.34.1
>
Reviewed-by: Somnath Kotur <somnath.kotur@xxxxxxxxxxxx>
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
