Re: [PATCH v8 2/4] scanf: remove redundant debug logs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri 2025-02-14 11:19:59, Tamir Duberstein wrote:
> Remove `pr_debug` calls which emit information already contained in
> `pr_warn` calls that occur on test failure. This reduces unhelpful test
> verbosity.
> 
> Note that a `pr_debug` removed from `_check_numbers_template` appears to
> have been the only guard against silent false positives, but in fact
> this condition is handled in `_test`; it is only possible for `n_args`
> to be `0` in `_check_numbers_template` if the test explicitly expects it
> *and* `vsscanf` returns `0`, matching the expectation.
> 
> Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx>

I am fine with the change. The debug messages have been obsoleted by
the 1st patch. The file:line information is more convenient to find
the failing test.

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux