On Thu, Feb 27, 2025 at 02:21:41PM -0800, John Fastabend wrote: > On 2025-02-27 11:52:04, Cong Wang wrote: > > On Wed, Feb 26, 2025 at 09:22:41PM +0800, Jiayuan Chen wrote: > > > Current wrapper function create_pair() is used to create a pair of > > > connected links and returns two fds, but it does not support unix sockets. > > > > > > Here we introduce socketpair() into create_pair(), which supports creating > > > a pair of unix sockets, since the semantics of the two are the same. > > > > Since it is only for UDS and only has effectively 1 line of code, how > > about just calling socketpair(AF_UNIX) in your patch 3/3? > > If we run that test with more than AF_UNIX it might be best as is. I > think there might be some value testing that flow on TCP/UDP even if > its not related to the bug. > > Thanks, > John Thanks, John! I'll make selftest cover more types of sockets.
