On Thu, 27 Feb 2025 11:19:33 +0100, Paolo Abeni <pabeni@xxxxxxxxxx> wrote: > On 2/24/25 10:22 AM, Peter Seiderer wrote: > > diff --git a/net/core/pktgen.c b/net/core/pktgen.c > > index ae5e81e62733..bb13a4591709 100644 > > --- a/net/core/pktgen.c > > +++ b/net/core/pktgen.c > > @@ -915,8 +915,13 @@ static ssize_t get_labels(const char __user *buffer, > > > > max = min(8, maxlen - i); > > len = hex32_arg(&buffer[i], max, &tmp); > > - if (len <= 0) > > + if (len < 0) > > return len; > > + > > + // return empty list in case of invalid input and/or zero value > > I'm sorry for nit picking, but C-99 comments should be avoided O.k., will change on next patch iteration, thanks for review! Regards, Peter > > Thanks, > > Paolo >
