On 2/26/25 12:37, Vasily Gorbik wrote:
On Tue, Feb 18, 2025 at 12:52:31AM +0100, Vasily Gorbik wrote:
On Mon, Feb 17, 2025 at 02:04:18PM +0100, Thomas Weißschuh wrote:
Commit 14be4e6f3522 ("selftests: vDSO: fix ELF hash table entry size for s390x")
changed the type of the ELF hash table entries to 64bit on s390x.
However the *GNU* hash tables entries are always 32bit.
The "bucket" pointer is shared between both hash algorithms.
--
On s390x the GNU algorithm assigns and dereferences this pointer to a
64bit value as a pointer to a 32bit value, leading to compiler warnings and
runtime crashes.
I would rephrase it as follows:
On s390, this caused the GNU hash algorithm to access its 32-bit entries as if they
were 64-bit, triggering compiler warnings (assignment between "Elf64_Xword *" and
"Elf64_Word *") and runtime crashes.
And take it via s390 tree.
Shuah, if you don't mind, may I get your Acked-by?
Hello Shuah,
friendly ping. Could you please respond with "Acked-by" if you don’t
mind me taking this patch via the s390 tree? Or let me know if you plan
to take it via your tree.
Thank you!
Yes. Please take this through s390 tree.
Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
thanks,
-- Shuah
