On Tue, Feb 18, 2025 at 07:39:44PM +0100, Arnaldo Carvalho de Melo wrote: > On Mon, Feb 10, 2025 at 04:23:49PM -0800, Andrii Nakryiko wrote: > > On Mon, Feb 10, 2025 at 10:31 AM Charlie Jenkins <charlie@xxxxxxxxxxxx> wrote: > > > On Wed, Feb 05, 2025 at 05:28:19PM -0800, Andrii Nakryiko wrote: > > > > On Tue, Feb 4, 2025 at 3:24 PM Charlie Jenkins <charlie@xxxxxxxxxxxx> wrote: > > > > So, can you please check and fix? > > > I think I am misunderstanding what you are saying. The patch that we are > > > discussing on is the patch to fix this? You are showing the output from > > > the patch that is being fixed in this series. > > Ah, it's me getting confused. It was the earlier perf commit that > > broke all this, makes sense. I just double-checked with your patches > > applied locally. It indeed fixes the issue, LGTM. > > Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx> > Thanks, b4 didn't pick this one, probably because you provided the Ack > for a previous version of this series, but the patch in it is the same > as in v2, so I'm keeping it, ok? > Also since you applied the patches and tested it, can I promote the tag > to Tested-by you? > Humm, there is a slight difference, checking that in the e-mails > thread... > + quiet = quiet_ > + Q = @ > > The above doesn´t have spaces surrounding the = sign, lemme see... Got it, the comment about consistency, etc. Can I use the Tested-by: for the v3 series? - Arnaldo
