Re: [PATCH net-next v3] selftests: net: add support for testing SO_RCVMARK and SO_RCVPRIORITY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 14, 2025 at 09:58:28PM +0100, Anna Emese Nyiri wrote:
> Introduce tests to verify the correct functionality of the SO_RCVMARK and 
> SO_RCVPRIORITY socket options.
> 
> Key changes include:
> 
> - so_rcv_listener.c: Implements a receiver application to test the correct 
> behavior of the SO_RCVMARK and SO_RCVPRIORITY options.
> - test_so_rcv.sh: Provides a shell script to automate testing for these options.
> - Makefile: Integrates test_so_rcv.sh into the kernel selftests.
> 
> v3:

I put the changelog under the "---" so that it won't be recorded in the
commit message. Nowadays maintainers usually record a lore link in the
commit message, so it's easy to reach the changelog from git log.

Example:
https://lore.kernel.org/netdev/056c8f4765a52179630b904e95fc4e3f26c02f2a.1739548836.git.petrm@xxxxxxxxxx/

You can use git-notes for that:
https://git-scm.com/docs/git-notes

> 
> - Add the C part to TEST_GEN_FILES.
> - Ensure the test fails if no cmsg of type opt.name is received
> in so_rcv_listener.c
> - Rebased on net-next.
> 
> v2:
> 
> https://lore.kernel.org/netdev/20250210192216.37756-1-annaemesenyiri@xxxxxxxxx/
> - Add the C part to TEST_GEN_PROGS and .gitignore.
> - Modify buffer space and add IPv6 testing option
> in so_rcv_listener.c.
> - Add IPv6 testing, remove unnecessary comment,
> add kselftest exit codes, run both binaries in a namespace,
> and add sleep in test_so_rcv.sh.
> The sleep was added to ensure that the listener process has
> enough time to start before the sender attempts to connect.
> - Rebased on net-next.
> 
> v1:
> 
> https://lore.kernel.org/netdev/20250129143601.16035-2-annaemesenyiri@xxxxxxxxx/
> 
> Suggested-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Suggested-by: Ferenc Fejes <fejes@xxxxxxxxxxx>
> Signed-off-by: Anna Emese Nyiri <annaemesenyiri@xxxxxxxxx>

Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx>
Tested-by: Ido Schimmel <idosch@xxxxxxxxxx>




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux