On Tue, Feb 11, 2025 at 12:00:49AM +0000, Quentin Monnet wrote: > 2025-02-10 10:34 UTC-0800 ~ Charlie Jenkins <charlie@xxxxxxxxxxxx> > > Q is exported from Makefile.include so it is not necessary to manually > > set it. > > > > Signed-off-by: Charlie Jenkins <charlie@xxxxxxxxxxxx> > > --- > > tools/arch/arm64/tools/Makefile | 6 ------ > > tools/bpf/Makefile | 6 ------ > > tools/bpf/bpftool/Documentation/Makefile | 6 ------ > > tools/bpf/bpftool/Makefile | 6 ------ > > tools/bpf/resolve_btfids/Makefile | 2 -- > > tools/bpf/runqslower/Makefile | 5 +---- > > tools/lib/bpf/Makefile | 13 ------------- > > tools/lib/perf/Makefile | 13 ------------- > > tools/lib/thermal/Makefile | 13 ------------- > > tools/objtool/Makefile | 6 ------ > > tools/testing/selftests/bpf/Makefile.docs | 6 ------ > > tools/testing/selftests/hid/Makefile | 2 -- > > tools/thermal/lib/Makefile | 13 ------------- > > tools/tracing/latency/Makefile | 6 ------ > > tools/tracing/rtla/Makefile | 6 ------ > > tools/verification/rv/Makefile | 6 ------ > > 16 files changed, 1 insertion(+), 114 deletions(-) > > > > > [...] > > > > diff --git a/tools/bpf/bpftool/Documentation/Makefile b/tools/bpf/bpftool/Documentation/Makefile > > index 4315652678b9f2e27e48b7815f3b9ddc70a57165..bf843f328812e10dd65a73f355f74e6825ad95b9 100644 > > --- a/tools/bpf/bpftool/Documentation/Makefile > > +++ b/tools/bpf/bpftool/Documentation/Makefile > > @@ -5,12 +5,6 @@ INSTALL ?= install > > RM ?= rm -f > > RMDIR ?= rmdir --ignore-fail-on-non-empty > > > > -ifeq ($(V),1) > > - Q = > > -else > > - Q = @ > > -endif > > - > > prefix ?= /usr/local > > mandir ?= $(prefix)/man > > man8dir = $(mandir)/man8 > > diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile > > index dd9f3ec842017f1dd24054bf3a0986d546811dc4..6ea4823b770cbbe7fd9eb7da79956cc1dae1f204 100644 > > --- a/tools/bpf/bpftool/Makefile > > +++ b/tools/bpf/bpftool/Makefile > > @@ -7,12 +7,6 @@ srctree := $(patsubst %/,%,$(dir $(srctree))) > > srctree := $(patsubst %/,%,$(dir $(srctree))) > > endif > > > > -ifeq ($(V),1) > > - Q = > > -else > > - Q = @ > > -endif > > - > > BPF_DIR = $(srctree)/tools/lib/bpf > > > > ifneq ($(OUTPUT),) > > > This is OK from bpftool's side, the GitHub mirror has a Makefile.include > included from both main and doc Makefiles, and where I can move this > definition. I am glad to hear. Thank you for helping me unify this infrastructure! - Charlie > > Acked-by: Quentin Monnet <qmo@xxxxxxxxxx> > > Thanks