On 04.10.24 21:00, Gabriel Krisman Bertazi wrote:
> Pedro Orlando <porlando@xxxxxxxxxx> writes:
>> From: Gabriela Bittencourt <gbittencourt@xxxxxxxxxx>
>>
>> Change utf8 kunit test filename and path to follow the style
>> convention on Documentation/dev-tools/kunit/style.rst
>>
>> Co-developed-by: Pedro Orlando <porlando@xxxxxxxxxx>
>> Signed-off-by: Pedro Orlando <porlando@xxxxxxxxxx>
>> Co-developed-by: Danilo Pereira <dpereira@xxxxxxxxxx>
>> Signed-off-by: Danilo Pereira <dpereira@xxxxxxxxxx>
>> Signed-off-by: Gabriela Bittencourt <gbittencourt@xxxxxxxxxx>
>> ---
>> fs/unicode/Makefile | 2 +-
>> fs/unicode/{ => tests}/.kunitconfig | 0
>> fs/unicode/{utf8-selftest.c => tests/utf8_kunit.c} | 0
>> 3 files changed, 1 insertion(+), 1 deletion(-)
>> rename fs/unicode/{ => tests}/.kunitconfig (100%)
>> rename fs/unicode/{utf8-selftest.c => tests/utf8_kunit.c} (100%)
>>
>> diff --git a/fs/unicode/Makefile b/fs/unicode/Makefile
>> index 37bbcbc628a1..d95be7fb9f6b 100644
>> --- a/fs/unicode/Makefile
>> +++ b/fs/unicode/Makefile
>> @@ -4,7 +4,7 @@ ifneq ($(CONFIG_UNICODE),)
>> obj-y += unicode.o
>> endif
>> obj-$(CONFIG_UNICODE) += utf8data.o
>> -obj-$(CONFIG_UNICODE_NORMALIZATION_KUNIT_TEST) += utf8-selftest.o
>> +obj-$(CONFIG_UNICODE_NORMALIZATION_KUNIT_TEST) += tests/utf8_kunit.o
>
> This breaks compilation for me.
>
> fs/unicode/tests/utf8_kunit.c:11:10: fatal error: utf8n.h: No such file or directory
> 11 | #include "utf8n.h"
> | ^~~~~~~~~
I encountered the same error when building -next using the Fedora
rawhide config today. Given that this patch landed in -next today I
suspect it might be due to this change, but I'm on the road and unable
to verify that right now.
Log:
https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-rawhide-x86_64/08642966-next-next-all/builder-live.log.gz
Cioa, Thorsten
> After this patch that local header is now in the parent directory.
>
> I'm building with:
>
> CONFIG_UNICODE=m
> CONFIG_UNICODE_NORMALIZATION_KUNIT_TEST=m
>
>> unicode-y := utf8-norm.o utf8-core.o
>>
>> diff --git a/fs/unicode/.kunitconfig b/fs/unicode/tests/.kunitconfig
>> similarity index 100%
>> rename from fs/unicode/.kunitconfig
>> rename to fs/unicode/tests/.kunitconfig
>> diff --git a/fs/unicode/utf8-selftest.c b/fs/unicode/tests/utf8_kunit.c
>> similarity index 100%
>> rename from fs/unicode/utf8-selftest.c
>> rename to fs/unicode/tests/utf8_kunit.c
>
