On Tue, Feb 11, 2025 at 9:47 AM Simon Horman <horms@xxxxxxxxxx> wrote: > > On Fri, Feb 07, 2025 at 06:38:41PM -0500, Tamir Duberstein wrote: > > Convert this very simple smoke test to a KUnit test. > > Hi Tamir, > > I think some text explaining why this change is being made is > warranted here. Hi Simon, I think that would be stating KUnit's raison d'etre? I followed Kees' lead as seen in https://lore.kernel.org/all/20240612195921.2685842-2-kees@xxxxxxxxxx/. In this case we saw the benefit right away: kernel test robot immediately spotted and reported a bug which I fixed in v2: https://lore.kernel.org/all/20250208-blackholedev-kunit-convert-v2-1-182db9bd56ec@xxxxxxxxx/. Weirdly this message is absent from lore, but should be in your inbox (and my reply to it *is* present on lore). > > > > Signed-off-by: Tamir Duberstein <tamird@xxxxxxxxx> > > --- > > I tested this using: > > > > $ tools/testing/kunit/kunit.py run --arch arm64 --make_options LLVM=1 --kconfig_add CONFIG_NET=y blackholedev > > ...
