>I did not undertand you intended to place the new header under the >'include' directory. I still have a preference for a really private >header that would under 'net/ipv4/' (IMHO the possible future divergence >of inet_fill_args and inet6_fill_args is not very relevant) but it's not >a deal breaker. Thanks for the advice, I will move the header file under 'net/ipv4' in the next version of this patch. Thanks, Yuyang On Thu, Feb 6, 2025 at 11:29 PM Paolo Abeni <pabeni@xxxxxxxxxx> wrote: > > On 2/4/25 10:19 AM, Yuyang Huang wrote: > > diff --git a/include/linux/igmp_internal.h b/include/linux/igmp_internal.h > > new file mode 100644 > > index 000000000000..0a1bcc8ec8e1 > > --- /dev/null > > +++ b/include/linux/igmp_internal.h > > I did not undertand you intended to place the new header under the > 'include' directory. I still have a preference for a really private > header that would under 'net/ipv4/' (IMHO the possible future divergence > of inet_fill_args and inet6_fill_args is not very relevant) but it's not > a deal breaker. > > /P >
