On Tuesday, February 4, 2025 11:18 PM, Fijalkowski, Maciej <maciej.fijalkowski@xxxxxxxxx> wrote: >On Tue, Feb 04, 2025 at 03:49:32PM +0100, Song, Yoong Siang wrote: [...] >> With above, IMHO, we no need to clear igc_tx_buffer::type, >> Are you agree? > >Yes, the contract should be that every routine that produces descriptors >should be setting the ::type explicitly. Sorry for not being clear from >beginning but I'm glad we're on the same page now. > >I'm afraid this single line should be send as a fix, though :< even >without your patch set empty descs could be mixed IGC_TX_BUFFER_TYPE_XDP >type. > Agree with you. I will send this single line as a fix patch to iwl-net Thanks & Regards Siang