Hi Jason, On 1/23/25 7:50 PM, Jason Gunthorpe wrote: > On Thu, Jan 23, 2025 at 06:10:54PM +0100, Eric Auger wrote: > >>> -/** >>> - * iommu_dma_compose_msi_msg() - Apply translation to an MSI message >>> - * @desc: MSI descriptor prepared by iommu_dma_prepare_msi() >>> - * @msg: MSI message containing target physical address >>> - */ >>> -static inline void iommu_dma_compose_msi_msg(struct msi_desc *desc, >>> - struct msi_msg *msg) >>> +static inline void msi_msg_set_msi_addr(struct msi_desc *desc, >>> + struct msi_msg *msg, u64 msi_addr) >> nit: msi_msg_set_addr(ess) may be enough as the populated fields are >> address_lo/hi > Not sure I follow, you suggest to use msi_msg_set_addr() as the > function name? Seems Ok Yes my minor point was just about removing the "msi" redundancy Eric > > Jason >
