Re: [PATCH bpf-next v3 12/14] selftests/bpf: test_xdp_veth: Add XDP broadcast redirection tests

To: Martin KaFai Lau <martin.lau@xxxxxxxxx>
Subject: Re: [PATCH bpf-next v3 12/14] selftests/bpf: test_xdp_veth: Add XDP broadcast redirection tests
From: Bastien Curutchet <bastien.curutchet@xxxxxxxxxxx>
Date: Wed, 29 Jan 2025 08:08:59 +0100
Cc: Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Jesper Dangaard Brouer <hawk@xxxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Eduard Zingerman <eddyz87@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yonghong.song@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Mykola Lysenko <mykolal@xxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Alexis Lothore <alexis.lothore@xxxxxxxxxxx>, Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <f0eb6d62-695b-461c-9a45-3926f590e413@linux.dev>
User-agent: Mozilla Thunderbird

Hi Martin,

On 1/29/25 12:03 AM, Martin KaFai Lau wrote:

On 1/28/25 1:57 AM, Bastien Curutchet (eBPF Foundation) wrote:

Set the tests to run serially to avoid conflicts with
test_xdp_veth_redirect


I think this has been fixed in v3?


Indeed, I forgot to update the commit log ...

Others lgtm also. Thanks for working on this.


Great, I'll send a V4 soon then, thank you.


Best regards,
Bastien

References:
- [PATCH bpf-next v3 00/14] selftests/bpf: Migrate test_xdp_redirect_multi.sh to test_progs
  - From: Bastien Curutchet (eBPF Foundation)
- [PATCH bpf-next v3 12/14] selftests/bpf: test_xdp_veth: Add XDP broadcast redirection tests
  - From: Bastien Curutchet (eBPF Foundation)
- Re: [PATCH bpf-next v3 12/14] selftests/bpf: test_xdp_veth: Add XDP broadcast redirection tests
  - From: Martin KaFai Lau