On 11/27/24 09:35, Maciej Wieczor-Retman wrote: ... > + switch (test->later) { > + case GET_USER_USER: > + /* Control group - properly tagger user pointer */ > + ptr = (void *)set_metadata((uint64_t)ptr, test->lam); > + break; s/tagger/tagged/ ? > + default: > + printf("Invalid test case value passed!\n"); > + break; > + } > + > + if (ioctl(fd, FIOASYNC, ptr) != 0) > + ret = 1; > + > + close(fd); > +error: > + munmap(ptr, PAGE_SIZE); > + return ret; > +} I'd really prefer that the theory of operation be in a code comment and not just in the changelog.