Re: [PATCH bpf-next v2 00/10] selftests/bpf: Migrate test_xdp_redirect_multi.sh to test_progs

Bastien Curutchet <bastien.curutchet@xxxxxxxxxxx> · Fri, 24 Jan 2025 11:25:44 +0100

Hi Stanislav

On 1/23/25 8:45 PM, Stanislav Fomichev wrote:
On 01/21, Bastien Curutchet (eBPF Foundation) wrote:
Hi all,

This patch series continues the work to migrate the *.sh tests into
prog_tests framework.

test_xdp_redirect_multi.sh tests the XDP redirections done through
bpf_redirect_map().

This is already partly covered by test_xdp_veth.c that already tests
map redirections at XDP level. What isn't covered yet by test_xdp_veth is
the use of the broadcast flags (BPF_F_BROADCAST or BPF_F_EXCLUDE_INGRESS)
and XDP egress programs.

Hence, this patch series add test cases to test_xdp_veth.c to get rid of
the test_xdp_redirect_multi.sh:
  - PATCH 1 to 5 rework test_xdp_veth to make it more generic and allow to
    configure different test cases
  - PATCH 6 adds test cases for 'classic' bpf_redirect_map()
  - PATCH 7 & 8 covers the broadcast flags
  - PATCH 9 covers the XDP egress programs
  - PATCH 10 removes test_xdp_redirect_multi.sh

Signed-off-by: Bastien Curutchet (eBPF Foundation) <bastien.curutchet@xxxxxxxxxxx>
---
Changes in v2:
- Use serial_test_* to avoid conflict between tests

Do I understand correctly that we want them serial mostly because of the
hard-coded namespace names? If yes, might be a good idea to follow up
(separately) with a way to generate unique name for each subtest and
unserialize them.

Yes, that's it. Ok, I'll send a V3 with random namespace names.

(If you have time/desire, I think there is a bunch of similar cases
where we have to serialize tests, might as well undo that).

I'll try to look at it.

I looked briefly through the series, looks good:

Acked-by: Stanislav Fomichev <sdf@xxxxxxxxxxx>

Best regards,
Bastien