Re: [PATCH net-next] selftests: net: give up on the cmsg_time accuracy on slow machines

[Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>]

On 1/16/25 03:01, Jakub Kicinski wrote:
> Commit b9d5f5711dd8 ("selftests: net: increase the delay for relative
> cmsg_time.sh test") widened the accepted value range 8x but we still
> see flakes (at a rate of around 7%).

you have undid the 8x change by this commit (without mentioning that)
[fine for me]

> Return XFAIL for the most timing sensitive test on slow machines.

code change looks fine for me, and does exactly that, so:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@xxxxxxxxx>

> Before:
>
>    # ./cmsg_time.sh
>      Case UDPv4  - TXTIME rel returned '8074us - 7397us < 4000', expected 'OK'
>    FAIL - 1/36 cases failed
>
> After:
>
>    # ./cmsg_time.sh
>      Case UDPv4  - TXTIME rel returned '1123us - 941us < 500', expected 'OK' (XFAIL)
>      Case UDPv6  - TXTIME rel returned '1227us - 776us < 500', expected 'OK' (XFAIL)
>    OK
>
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>