On Wed, 15 Jan 2025 11:13:22 +0800 Liu Ye wrote:
> From: liuye <liuye@xxxxxxxxxx>
>
> From: Liu Ye <liuye@xxxxxxxxxx>
too many From lines.
> Address Null pointer dereference in rtattr_pack.
I think size is 0 in the bad case, so it's more of an undefinied
behavior.
> Flagged by cppcheck as:
> tools/testing/selftests/net/ipsec.c:230:25: warning: Possible null pointer
> dereference: payload [nullPointer]
> memcpy(RTA_DATA(attr), payload, size);
> ^
> tools/testing/selftests/net/ipsec.c:1618:54: note: Calling function 'rtattr_pack',
> 4th argument 'NULL' value is 0
> if (rtattr_pack(&req.nh, sizeof(req), XFRMA_IF_ID, NULL, 0)) {
> ^
> tools/testing/selftests/net/ipsec.c:230:25: note: Null pointer dereference
> memcpy(RTA_DATA(attr), payload, size);
> ^
> Fixes: 70bfdf62e93a ("selftests/net/ipsec: Add test for xfrm_spdattr_type_t")
Your Sign-off needs to be right after fixes.
> ---
> V2: Modify description.
> Add code checking tools.
> Separating family and given name in Signed-off-by line.
> Modify code format.
> Add fixes.
> ---
Please post v3 as a new thread (not in reply to).
--
pw-bot: cr
