On 1/10/25 12:13, Filipe Xavier wrote: > Em 07/01/2025 13:23, Joe Lawrence escreveu: > >> On Thu, Jan 02, 2025 at 03:42:10PM -0300, Filipe Xavier wrote: >>> This new test makes sure that ftrace can trace a >>> function that was introduced by a livepatch. >>> >> Hi Filipe, >> >> Thanks for adding a test! >> >> Aside: another similar test could verify that the original function, in >> this case cmdline_proc_show(), can still be traced despite it being >> livepatched. That may be non-intuitive but it demonstrates how the >> ftrace handler works. > > Thanks for the review Joe! > > I have fixed all points mentioned below, > > and have a patch ready to submit. > > Do you believe that this other similar test could be sent later, > > or is it required in this patch? > The second test could be added later if you like, either way is fine w/me. Thanks, -- Joe