Hello Simon, On Fri, Dec 06, 2024 at 03:09:18PM +0000, Simon Horman wrote: > On Wed, Dec 04, 2024 at 08:40:45AM -0800, Breno Leitao wrote: > > Add a new selftest for netconsole that tests the userdata entry limit > > functionality. The test performs two key verifications: > > > > 1. Create MAX_USERDATA_ITEMS (16) userdata entries successfully > > 2. Confirm that attempting to create an additional userdata entry fails > > > > The selftest script uses the netcons library and checks the behavior > > by attempting to create entries beyond the maximum allowed limit. > > > > Signed-off-by: Breno Leitao <leitao@xxxxxxxxxx> > > --- > > MAINTAINERS | 2 +- > > .../selftests/drivers/net/netcons_overflow.sh | 67 ++++++++++++++++++++++ > > 2 files changed, 68 insertions(+), 1 deletion(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 8af5c9a28e68c4b6a785e2e6b82db20b3cf59822..62192db4641a4056d1eab911f5c141fb37eaed36 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -16092,7 +16092,7 @@ S: Maintained > > F: Documentation/networking/netconsole.rst > > F: drivers/net/netconsole.c > > F: tools/testing/selftests/drivers/net/lib/sh/lib_netcons.sh > > -F: tools/testing/selftests/drivers/net/netcons_basic.sh > > +F: tools/testing/selftests/drivers/net/netcons\* > > > > NETDEVSIM > > M: Jakub Kicinski <kuba@xxxxxxxxxx> > > diff --git a/tools/testing/selftests/drivers/net/netcons_overflow.sh b/tools/testing/selftests/drivers/net/netcons_overflow.sh > > Nit: I think you need to add netcons_overflow.sh to > tools/testing/selftests/drivers/net/Makefile Good catch. I will fix it and send a v2. Thanks for the review, --breno